Griffith - media collection manager
May 21, 2012, 07:12:52 PM *
Welcome, Guest. Please login or register.

Login with username, password and session length
News: Please check ask.griffith.cc and wiki.griffith.cc before asking questions.
 
   Home   Help Search Login Register  
Pages: [1]   Go Down
  Print  
Author Topic: [SOLVED] PluginMovieCineMovies.py : patch not retained?  (Read 613 times)
CinéphOli
Jr. Member
**
Offline Offline

Posts: 87



View Profile
« on: May 08, 2011, 06:35:33 PM »

Hello,
I see that latest rev 1544 modified the plugin for www.cinemovies.fr, for which I submitted a patch 2 or 3 weeks ago (sent by e-mail to both Piotr and Vasco Nunes), but apparently none of my suggestions have been retained, which is rather confusing…

The rev 1544 still :
- does not always collect the right poster,
- does not collect the trailer address,
- does not manage minutes-only duration,
- still leaves an extraneous comma at the end of some fields,
- does not address the problem of multiple directors and/or multiple screenwriters,
- does not collect the plot (summary).

My patch addressed all those issues. Maybe if  was not top notch Python programming (I'm no specialist), but at least it worked…
I join herewith a copy of the .py file I modified (it's impossible to join a .diff)
« Last Edit: June 08, 2011, 05:27:01 PM by CinéphOli » Logged

Using Griffith v0.13 r1621 on Linux Ubuntu
Griffith SQL for Dummies
mike
Global Moderator
Hero Member
*****
Offline Offline

Posts: 996


View Profile WWW
« Reply #1 on: May 12, 2011, 09:09:42 PM »

Sorry, I didn't get the modified version.
I checked only the results of my automatic tests for the plugins and made some small fixes based on them.
Please can you send me your version of the plugin and the titles of the movies which are broken by the original version of the plugin.
Logged
CinéphOli
Jr. Member
**
Offline Offline

Posts: 87



View Profile
« Reply #2 on: May 13, 2011, 04:09:15 PM »

Will do, but not tonight. Probably this week-end.
Logged

Using Griffith v0.13 r1621 on Linux Ubuntu
Griffith SQL for Dummies
CinéphOli
Jr. Member
**
Offline Offline

Posts: 87



View Profile
« Reply #3 on: May 14, 2011, 02:35:48 PM »

Done, I e-mailed to you a copy of the patch and a series of screenshots that illustrate the differences.
Logged

Using Griffith v0.13 r1621 on Linux Ubuntu
Griffith SQL for Dummies
mike
Global Moderator
Hero Member
*****
Offline Offline

Posts: 996


View Profile WWW
« Reply #4 on: May 22, 2011, 12:50:48 PM »

Checked in with rev. 1546.
Thanks for your work!
Logged
Pages: [1]   Go Up
  Print  
 
Jump to:  

Powered by MySQL Powered by PHP Powered by SMF 1.1.16 | SMF © 2006-2007, Simple Machines Valid XHTML 1.0! Valid CSS!