[SOLVED] Extensions toolbar next to main toolbar

[CinéphOli]

I wish it could be possible to move the extensions toolbar up next to the main toolbar, it would save a display line on the screen.

[mike]

I attached a modified griffith.glade file. Try it out. It is a zip archive. Remove the .txt extension of the file and decompress the archive. Replace the original griffith.glade with that one in the archive.

[CinéphOli]

oops, it doesn't unzip:

Code:

$ unzip griffith.glade.zip
Archive:  griffith.glade.zip
warning [griffith.glade.zip]:  91 extra bytes at beginning or within zipfile
  (attempting to process anyway)
file #1:  bad zipfile offset (local header sig):  91
  (attempting to re-compensate)
  inflating: griffith.glade          
  error:  invalid compressed data to inflate

Tried with:
UnZip 6.00 of 20 April 2009, by Debian. Original by Info-ZIP.
7-Zip 9.04 beta  Copyright (c) 1999-2009 Igor Pavlov  2009-05-30

[mike]

Second try with another extensions. 

[CinéphOli]

Yes, the extraction worked flawlessly this time, thank you.

[CinéphOli]

I tried this new version of griffith.glade, it works as expected, thank you.

[Hernals]

I tried it, too, and it works, but:
I neither can edit a movie nor create a new movie (nothing happens when I push the button or select "new" in the menu), so I skipped back 

I found "griffith.glade" at
http://svn.berlios.de/svnroot/repos/griffith/trunk/glade/

Meanwhile I have so many small updates, that I would loose a lot If I would have to reinstall griffith 0.12.1 some bad day ...
A 0.12.2 would help ... 

[CinéphOli]

I checked again with a pristine installation of Griffith, it works perfectly well, and I can create/edit a movie.
Maybe a Windows/linux difference?

BTW, did you try with mike's file "out of the box" (without changing anything and by replacing your copy of griffith.glade) or did you copy/paste the modified parts in your copy of griffith.glade to preserve your own changes?

[Hernals]

I renamed griffith.glade to griffith.glade.old and used the downloaded one without any changes.
I compared both files with my editor and found about 8 different parts. Can you please tell me the numbers (begin - end) of the responsible lines for moving the tool-bar?! Then I can try copy/past.

Now I think I solved it:

1. I copied from new griffith.glade the lines
685 <packing>
to line
703 <\packing>
into my griffith.glade

2. I copied from new griffith.glade the line
852 <!--
and the line
869 -->
into my griffith.glade (I think it removes the old definition)

[mike]

Did it work now?
I'm not sure if I should add the changes to the official release. If I would do so I think I have to change the new icons to a smaller size before. What do you think? Should the extensions toolbar always be besides the main toolbar?

[Hernals]

Hi Mike,
if you asked me:
It works fine, no more problems until now!
The button-bar could be less high, only the button "marks all ... as seen" is a little bit to big (it is the one I imported from http://forum.griffith.cc/index.php/topic,1561.0.html)
I think there is absolutely no reason to waste lines for a own small group of buttons, don't take care of smartphone-user 

[CinéphOli]

Hello mike,

I see that the toolbars are detachable, but they can not be re-attached in a different position. The ideal solution would of course to leave the choice to the user, and have several "docking" possibilities for the toolbars: aligned vertically above and/or below the quick filter line, or next to each other, or even vertically along the window side, why not.

If not possible, then I would say next to each other (of course, since it was my request at the beginning of this post ). But this works only as long as there are not too many extensions…

Now, the size of the icons. Well, one size does not fit all, does it? It all depends on what window theme the user chose, the size of the other icons in the main toolbar varying accordingly to this theme (those being in SVG). So, again, the solution (I guess) would be SVG icons that would rescale automatically. Fixed size PNG icons won't please everybody, but it is true that I may have designed slightly too big icons, shall I reduce them? The set I made is 32px high (I don't understand why Hernals finds one button bigger than the others, it is larger, true, but not higher …), I can easily do more sets at 30px and 28px high (well, anyone can do that, it's really not difficult with Inkscape…).

[Hernals]

... (I don't understand why Hernals finds one button bigger than the others, it is larger, true, but not higher …), ...

I only imported one button "marks all ... as seen"

The buttons have all the same height, but the image is bigger.

[CinéphOli]

Sorry, Hernals, I misread you. Your toolbar illustrates precisely the problem of SVG vs PNG icons, of scalable size vs fixed size. If you tell me what height would suit you, I can quickly recreate an icon of that size for you.

[Hernals]

... If you tell me what height would suit you, I can quickly recreate an icon of that size for you.

Thank you! I would prefer that the toolbar (now 45px) has the same hight like the filterbar below (30px). That means, that the image of the button "marks all ... as seen" (now 30px) should have the same maximum size like the others: 16px.

By the way, maybe you find a new button for "Filter leeren" (Filterbar), it is the same like above "Poster entfernen" (Toolbar).