.toprettyxml() to be avoided?

[CinéphOli]

Hello,

While working on the module PluginExportGCstar.py, I noticed that the method (I hope it is the right word, my OOP vocabulary is rather weak…) .toprettyxml() used in <griffith>/lib/plugins/export/__init.py__ does NOT produce correct XML.

It adds extra carriage returns, tabs and/or whitespaces to the text nodes, which is simply wrong/illegal. Such whitespaces count in XML text nodes, they are not neutral (there are discussions about this on the internet). And because of that, the data imported into GCstar are misaligned, at least in some fields (actors, summary, …). I suppose this is true for the other export modules as well, but I didn't have a look at them yet.

On the contrary, the method .toxml() produces correct XML, and IMO should be privileged. I know that the one line output is hardly human readable, but at least it is correct and can easily be correctly beautified with a utility like xmllint:

Code:

xmllint --format input.xml > output.xml

Just my 2 (euro)cents.

PS: should I rather post this on the developers' list? I subscribed recently.

[mike]

First, yes you are right. .toxml() is the better choice. I took .toprettyxml() in the past for debugging and comparing reasons. But in production you only need .toxml().

And yes the mailing list is a good place for such things.